Fix custom splits during preprocessing - #208
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the handling of user-provided
custom_splitsduring preprocessing.Changes
_utils.pycustom_splits_from_anno()function.sample_idcolumn to align the resulting row indices with the sample IDs that are sorted during preprocessing._base_pipeline.pyBasePipeline._base_preprocessor.pyBasePreprocessor.custom_splitsattribute to the constructor.custom_splitsinformation toPairedUnpairedSplitter._datasplitter.pyPairedUnpairedSplitter.custom_splitsattribute to the constructor.split()so that it checks whether custom splits exist._per_modality_splits_from_custom_splits().Testing
Tested locally with:
ImagixIMG_TO_IMGexample using 2D MedMNIST PNG data and an annotation file with acustom_splitscolumnImagix3DIMG_TO_IMGexample using predefined annotation-based train/validation/test splitsIn both cases, preprocessing used the custom split path via
PairedUnpairedSplitter.