Skip to content

fix: stop the RoleArn synth test printing AWS credentials into CI logs #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davehorton merged 1 commit into from
Aug 26, 2026
Merged

fix: stop the RoleArn synth test printing AWS credentials into CI logs #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/synth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,8 +722,14 @@ test('AWS speech synth tests by RoleArn', async(t) => {
// the same vendor/voice/language, and identical text would hit that cache entry,
// making servedFromCache true and this assertion fail.
text: 'This is a roleArn test. This is only a roleArn test',
// Without this, synthPolly returns the mediajam streaming params string, which
// embeds accessKeyId/secretAccessKey/sessionToken (see lib/synth-audio.js).
// Every other synth test in this file renders for caching; this one did not,
// so it printed live credentials into a public CI log.
renderForCaching: true,
});
t.ok(!opts.servedFromCache, `successfully synthesized aws by roleArn audio to ${opts.filePath}`);
// Deliberately does not interpolate opts.filePath -- it can carry credentials.
t.ok(!opts.servedFromCache, 'successfully synthesized aws by roleArn audio');
} catch (err) {
console.error(err);
t.end(err);
Expand Down
Loading