Repository navigation
Elemental Showdown: review findings (#158) - #181
Merged
Merged
Conversation
jacobcheatley
added this pull request to stack #182
September 22, 2026 00:37
jacobcheatley
marked this pull request as ready for review
September 22, 2026 00:38
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
…ress Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
…empt Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
…once Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
…shows Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
The pill sits dead centre, where a thumb naturally goes down, and it kept its own pointerdown from the slider so that its tap could cast a draw. A drag from there moved nothing. The pill lets the press through and the gesture casts on release, as one that starts anywhere else does: the draw when the press went down on the pill and the seam never left the middle, nothing when a drag came back to it. Chrome still sends the tap's click to the pill after the slider has taken the pointer, so the click casts only when no pointer is behind it, which is how an assistive technology's activation arrives. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH
jacobcheatley
force-pushed
the
fix/158-showdown-review-findings
branch
from
September 22, 2026 01:08
6326b86 to
51b6bee
Compare
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Each Story field is capped at a phone's width, so several sit side by side on a desktop, and beside a fine pointer the row grows a button at each end because a mouse has no swipe. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
A paper ring and a press on the pill say it can be tapped, and the first Matchup's hint says what the tap casts. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #158. Fixes from a two-axis review (standards and spec) of the whole Elemental Showdown stack, one commit each.
Behaviour
::ffff:a.b.c.d) is rate-limited as its IPv4 address; before, every one of them shared the0:0:0:0bucket.ShownElement(id, name, emoji, colour): Common/Rare never leaves the server.aria-valuenowis the seam's height so Up still increases it.navigator.clipboardlogs and leaves the share label alone instead of throwing.Tidy
revealForinvote-reveal.ts(no more type cycle);Voteris a branded uuid;matchupKeytakes the pair; oneMosaic; onepercent, one met colour, one shared test Element factory.Verification
Every behaviour fix has a test that failed on the old code.
bun run checkandbun run testgreen (46 files, 605 tests); the e2e suite passes against the production Docker image; keyboard, drag, pill-tap and reveal driven in headless Chromium against the local database.🤖 Generated with Claude Code
https://claude.ai/code/session_01AVEtgjCoEbaNHrYfzyCRNH