Skip to content

Show the build dependencies in the README - #59

Open
chucktilbury wants to merge 2 commits into
j6t:masterfrom
chucktilbury:master
Open

Show the build dependencies in the README#59
chucktilbury wants to merge 2 commits into
j6t:masterfrom
chucktilbury:master

Conversation

@chucktilbury

Copy link
Copy Markdown

I added a couple of lines in the README to show the build dependencies for a recent Debian system.

@hartwork hartwork left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chucktilbury the current form seems to hurt more than help, please see details below. I recommend to clarify with @j6t what the requirements would be, and then I can jump back in for detailed review as needed.

Comment thread README

Johannes Sixt <j6t@kdbg.org>

Build dependencies for Debian 6.12

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean Debian 12? Latest stable "trixie" is Debian 13, and I don't consider anything older than 13 to be worth supporting, personally.

Comment thread README
Johannes Sixt <j6t@kdbg.org>

Build dependencies for Debian 6.12
sudo apt install libkf6iconthemes-dev libkf6xmlgui-dev libkf6windowsystem-dev

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not all direct dependencies, as far as CI is concerned:

- name: Install build dependencies
env:
kde_major: ${{ matrix.kde_major }}
run: |-
set -x
if [[ ${kde_major} = 5 ]]; then
extra_packages=(
libkf5config-dev
libkf5i18n-dev
libkf5iconthemes-dev
libkf5windowsystem-dev
libkf5xmlgui-dev
qtbase5-dev
)
else
sudo sed 's,noble,questing,g' -i /etc/apt/sources.list.d/ubuntu.sources # Ubuntu 25.10
extra_packages=(
binutils
libkf6config-dev
libkf6i18n-dev
libkf6iconthemes-dev
libkf6windowsystem-dev
libkf6xmlgui-dev
qt6-base-dev
)
fi
sudo apt-get update
sudo apt-get remove --yes libegl-mesa0 mesa-libgallium # addresses conflicts
sudo apt-get install --yes --no-install-recommends \
cmake \
extra-cmake-modules \
nasm \
"${extra_packages[@]}"

@chucktilbury

chucktilbury commented Apr 5, 2026 via email

Copy link
Copy Markdown
Author

@j6t

j6t commented Apr 5, 2026

Copy link
Copy Markdown
Owner

Thank you for your contribution. A few comments.

  • The text in the README file has a certain flow and structure. It isn't just a collection of random sentences, so that it would be fine to slap on another sentence at the end. Please do take the time to find the proper place where to insert the new text.
  • I would prefer not to hard-code the list of dependencies in the README text again. A reference to an existing list of dependencies would be appreciated, for example, "see debian/control for a list of potential build dependencies".
  • Please do not add fixup commits. Squash the commits into one commit that pretends it did everything perfectly the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants