fix(ci): drop --if-present from the lerna build step so the publish can actually run - #571
Open
izzywdev wants to merge 1 commit into
Open
fix(ci): drop --if-present from the lerna build step so the publish can actually run#571izzywdev wants to merge 1 commit into
izzywdev wants to merge 1 commit into
Conversation
…d it The publish workflow ran for the first time in its life after #563 fixed its owner guard, and failed immediately: ERR! lerna Unknown arguments: if-present, ifPresent The flag was inherited from the workflow's original form and had never executed — the job was gated on an owner that does not exist, so every run for the life of the file was a skip. Fixing the guard is what first ran this line, which is the same lesson the guard itself carried: a step that never runs is indistinguishable from a step that works. `lerna run <script>` already skips packages that do not define it, so the flag was never needed. Verified locally against this tree: 24 projects built, exit 0. Three master pushes have failed on this since the merge (2d98dde, 63125dc, 2951376). Nothing has published yet.
Contributor
Automated code review (gate-code-review)Credit balance is too low Report-only — this check never blocks merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
packages-publish.ymlran for the first time in its life after #563 fixed its owner guard — and failed immediately:lerna 10 removed
--if-present. The flag was inherited from the workflow's original form and had never executed, because the job was gated on an owner that does not exist, so every run for the life of the file was a skip. Fixing the guard is what first ran this line.That is the same lesson the guard itself carried, one layer down: a step that never runs is indistinguishable from a step that works.
Three master pushes have failed on this since the merge (
2d98dde8,63125dc4,2951376c). Nothing has published yet.🔄 Type of Change
🧪 Testing
Test Configuration:
Test Instructions
npx lerna run build # 24 projects, exit 0Ran against this tree:
Successfully ran target build for 24 projects, exit 0. Also confirmednpx lerna run --helpno longer lists--if-presenton lerna 10.0.0, which is what CI resolves.The flag was never needed either way —
lerna run <script>already skips packages that do not define it.🔧 Implementation Details
Changes Made
One line in
.github/workflows/packages-publish.yml, plus a comment recording why the flag was there and why removing it is safe.Code Quality
Documentation
🚨 Breaking Changes
None.
📋 Checklist
Pre-submission
Code Quality
🎯 Reviewers
📝 Additional Notes
Deployment Notes
On merge this should publish ~18 packages under
@izzywdev/fuzefront-*for the first time. Worth watching the run rather than assuming green means published — the 8 transform tests and the--dry-runstep both already pass, so the remaining unknowns are the registry write itself and thepackages: writetoken scope.Future Work
backend/Dockerfile,backend/security/Dockerfile,frontend/Dockerfileandservices/billing-service/Dockerfiletonpm ci(FFRNT-254 follow-up). feat(identity): namespace + adoption gates, L1 ref_index, lockfile-honouring images, and a publish path that actually publishes #563 attempted and reverted this; master's e2e runs since confirm the revert was correct —OIDC PlumbingandE2E (sign-in)are both green again post-merge. The exemptions inscripts/check-dockerfile-lockfile.mjscarry the reasoning.Permit sync ran WITHOUT the app registry — every self-registered product policy was omitted, caused bycolumn "slug" does not existonapps. Fails soft, so products registered through the app registry silently end up with no roles in Permit.🔄 Backwards Compatibility
Generated by Claude Code