Repository navigation
Say where a hit was said, and follow the conversation it names. - #57
Merged
Merged
Conversation
itz4blitz
requested changes
Oct 20, 2026
itz4blitz
left a comment
Owner
There was a problem hiding this comment.
The context line looks right, and the follow-the-open-conversation and stale-guard fixes from #55 are good. A few things:
- This inherits #55's switcher bug: the "Search messages" row fills the field with
set_text, which emits nothing, so nothing is asked (side.rs:439here). See the #55 review. - The picked row survives a conversation switch. The re-ask deliberately keeps
picked(side.rs:232,:576), and the answer handler only setspage.hits. Once the new answer lands, the lit row and Enter's target are a different message the user never chose. If the index is out of range, Enter falls through to the network ask in #58. Please clearpickedwhen the scope's target changes, or when an answer for a different target lands. - Only the Conversation scope follows a switch here (
:241), so This space stays on the old Space. #58 fixes that, so this is fine as a stack. held()(:594,:975) scans the sidebar rows and every tree once per distinct hit conversation per frame, plusopen_with_spaceevery frame. Resolving the context line once when an answer lands would keep render cheap with many hits.- There are no tests for the follow/re-ask behaviour or the context line.
unRekable
force-pushed
the
feat/search-pane-scopes
branch
from
October 20, 2026 14:53
81ef9a9 to
89f3e40
Compare
unRekable
force-pushed
the
feat/search-hit-rows
branch
from
October 20, 2026 15:22
c146e3f to
7fb3442
Compare
itz4blitz
force-pushed
the
feat/search-pane-scopes
branch
from
October 24, 2026 16:50
afc49e6 to
345c650
Compare
itz4blitz
force-pushed
the
feat/search-hit-rows
branch
from
October 24, 2026 16:55
7fb3442 to
6730d04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #55 — the search-pane work; merge that first. Against
feat/search-pane-scopesso only this slice shows.What
The search pane's result rows take the anatomy
docs/product/05-navigation.md§5 draws for them: a context line of the network's mark, the Space the conversation sits in before the conversation's name, and the date at the end — the match stays emphasised below.Two refinements from review of #55:
Tests
cargo check -p tinyclient --features guiclean,cargo test -p tinyclient --features gui350 passed.