Repository navigation
Decode cached images by content and wrap tooltip text - #22
Merged
Merged
Conversation
Detect still-image formats from bytes because media cache filenames have no extensions. Keep small sources at their native size. Constrain tooltip text to its flex slot so failure reasons wrap within the background. Cover extensionless PNG, JPEG, and WebP files and update the design docs. All 309 GUI tests pass, with one ignored. Co-Authored-By: GPT-6 <noreply@openai.com>
itz4blitz
approved these changes
Oct 17, 2026
itz4blitz
left a comment
Owner
There was a problem hiding this comment.
Cache files have no extension, and ImageReader::with_guessed_format reads the bytes the way the macOS path already does. The thumbnail edge is now capped at the source's long side, so a small picture is no longer scaled up to the requested size. The tooltip text sits in a shrinking flex slot inside the 240-point box, and the shortcut stays on one line. macOS, Linux, and Windows are green on 2d1d7e1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloaded Discord images failed to display on Linux/Windows because media cache filenames are extensionless hashes, while the still-image decoder selected the format from the filename. The error tooltip also let its text extend beyond its background.
Detect image formats from their bytes, as the avatar decoder already does, and prevent thumbnail decoding from enlarging a smaller source. Give tooltip text a shrinking, wrapping flex slot within the 240px box while keeping shortcut labels on one line. Update the system and media design specifications.
Validation:
git diff --checkpasses. Tooltip wrapping was not visually verified after the change.