Skip to content

Clear publish workflow annotations - #68

Merged
itz4blitz merged 1 commit into
masterfrom
fix/ci-annotation-cleanup
Oct 24, 2026
Merged

itz4blitz merged 1 commit into
masterfrom
fix/ci-annotation-cleanup

Conversation

@itz4blitz

Copy link
Copy Markdown
Owner

Summary

  • Bump the Docker publish actions to releases that run on Node 24, so GitHub stops forcing checkout, setup-node, pnpm/action-setup, Codecov, and the Docker actions off Node 20.
  • Pin both jobs to ubuntu-24.04. ubuntu-latest is moving to Ubuntu 26 through November 19, and this workflow just published successfully on the current image.
  • Run CI on Node 22, which is what the backend and frontend images already use.
  • Fix the lint warnings that job annotated: Seerr spec return types and require-await, Emby nullable string checks, and the Plex WebSocket console.log.

The same lint rules still warn across the rest of the app. This PR only covers the warnings from the v0.6.6 publish run.

Merging will publish images again, because the workflow runs on pushes to master.

Test plan

  • Lint, typecheck, and unit tests pass on the pull request
  • The test job no longer annotates Node 20 actions, ubuntu-latest, or the provider warnings above
  • The image build jobs run and do not push

The lint job warned on Node 20 actions, the Ubuntu 26 runner migration, and a handful of provider lint warnings. Bump those actions onto Node 24, pin the runner, and test on Node 22 so CI matches the images.
@itz4blitz
itz4blitz merged commit db7d385 into master Oct 24, 2026
4 checks passed
@itz4blitz
itz4blitz deleted the fix/ci-annotation-cleanup branch October 24, 2026 17:03
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants