Skip to content

chore(provider-arr): address #57 review follow-ups - #66

Merged
itz4blitz merged 1 commit into
itz4blitz:masterfrom
vbrzezina:chore/arr-ingestion-review-followups
Oct 16, 2026
Merged

itz4blitz merged 1 commit into
itz4blitz:masterfrom
vbrzezina:chore/arr-ingestion-review-followups

Conversation

@vbrzezina

Copy link
Copy Markdown
Contributor

Follow-ups from the approved review of #57. All of them were non-blocking.

  • FileDiscoveryService.isIncluded comment: corrected. Only exclude patterns are matched against the base name; include patterns match the filename as given. Behaviour is unchanged.
    • One latent inconsistency remains. Patterns are anchored, so a direct file path combined with a literal include pattern such as sonarr.txt won't match, while *.txt does. The default *arr configs use * globs, so nothing is affected today. Switching includes to the base name would be a one-line change if you'd like it.
  • Exception detection: finalizeArrLogEntry and isArrLogContinuation now share one rule. It accepts any namespace-qualified type name ending in Exception, including a bare System.Exception and types outside the old allowlist (Npgsql.PostgresException, SQLite.SQLiteException, Polly.Timeout.TimeoutRejectedException, FluentValidation.ValidationException). Ordinary sentences such as Request failed. Exception: x are not matched. Tests cover both cases.
  • parseArrLogLineWithContext docblock: trimmed to what is specific to that function. The blank-line comment is kept.
  • Processor spec title: now matches its assertion, which is that an 8-digit fraction line is kept as a continuation.

pnpm build, lint, typecheck and test all pass.

@vbrzezina

Copy link
Copy Markdown
Contributor Author

Status: ready for review. These are the non-blocking follow-ups from the #57 review. They are small and independent of the other PRs.

@itz4blitz
itz4blitz merged commit c44960e into itz4blitz:master Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants