Repository navigation
chore(provider-arr): address #57 review follow-ups - #66
Merged
itz4blitz merged 1 commit intoOct 16, 2026
Merged
Conversation
Contributor
Author
|
Status: ready for review. These are the non-blocking follow-ups from the #57 review. They are small and independent of the other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the approved review of #57. All of them were non-blocking.
FileDiscoveryService.isIncludedcomment: corrected. Only exclude patterns are matched against the base name; include patterns match the filename as given. Behaviour is unchanged.sonarr.txtwon't match, while*.txtdoes. The default *arr configs use*globs, so nothing is affected today. Switching includes to the base name would be a one-line change if you'd like it.finalizeArrLogEntryandisArrLogContinuationnow share one rule. It accepts any namespace-qualified type name ending inException, including a bareSystem.Exceptionand types outside the old allowlist (Npgsql.PostgresException,SQLite.SQLiteException,Polly.Timeout.TimeoutRejectedException,FluentValidation.ValidationException). Ordinary sentences such asRequest failed. Exception: xare not matched. Tests cover both cases.parseArrLogLineWithContextdocblock: trimmed to what is specific to that function. The blank-line comment is kept.pnpm build,lint,typecheckandtestall pass.