fix(artifacts): review follow-ups — id-cache invalidate after the queued write; honest dedupe scope - #320
Merged
Conversation
… queued write; state the dedupe's real scope Adversarial review of #318 found: - invalidateSidecarIdCache ran BEFORE the (now queued) append, so a watcher rebuild in between could read the old sidecar and leave a just-created artifact unmapped until the next TTL. Moved after the write commits. - applyGitTreatment was an unused import. - The 'replays are idempotent' claim was overstated: the dedupe key is (DESKTOP sessionId, toolUseId), and a Claude Code --resume mints a fresh desktop id (session-manager.ts randomUUID()), so a resumed CC conversation is re-recorded once per resume — bounded and crash-free, not growth-free. Native sessions keep their id and are fully idempotent. The type comment and docs/artifacts.md now say exactly that and name the follow-up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from an adversarial review of #318 (no behaviour change users would notice):
invalidateSidecarIdCachenow runs afterappendVersionresolves (the append is queued, so invalidating first left a small window where the watcher could rebuild from the old sidecar).applyGitTreatmentimport.--resumemints a fresh id, so a resumed CC conversation is re-recorded once per resume (bounded, crash-free; not growth-free). Follow-up captured in the workspace ROADMAP.🤖 Generated with Claude Code