Skip to content

ui: Fix/theme selection cutoff - #45

Merged
itsPronay merged 7 commits into
itsPronay:masterfrom
agustux:fix/theme-selection-cutoff
Oct 24, 2026
Merged

itsPronay merged 7 commits into
itsPronay:masterfrom
agustux:fix/theme-selection-cutoff

Conversation

@agustux

@agustux agustux commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Fixes the segmented button cutoff problem (closes #40) with a dropdown instead. I think this looks pretty clean:
Screenshot_20261023_081837_Blankee
Screenshot_20261023_081840_Blankee

@itsPronay itsPronay changed the title Fix/theme selection cutoff ui: Fix/theme selection cutoff Oct 23, 2026

@itsPronay itsPronay left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, i am against using a dropdown for theme selection. i would prefer a one-click change since there aren’t too many options to choose from. The system text displays fine on my device, so the issue is with lower-density screens.

Have you tried reducing the horizontal padding in each box? IMO, that should fix the issue without chaning the original design. Maybe reduce by 4 dp horizontally for each card and see how it looks ?

@agustux

agustux commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

I have but it looks awkward with the "system" part being to close to the edges. Another simple solution that comes to mind is changing the name from "System" to "Auto" or something, means the same in some apps.

@itsPronay

Copy link
Copy Markdown
Owner

@agustux yea, set it to Auto, better

This reverts commit 1197ffb.
We're going to replace "System" with "Auto" instead

@agustux agustux left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to revert and check replacing "System" with "Auto"

@agustux
agustux requested a review from itsPronay October 23, 2026 20:10

@agustux agustux left a comment •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid conflict with master because the AMOLED PR got merged

I rerequested review trying to approve your requested changes sorry

Comment thread app/src/main/res/values-bn/strings.xml
@itsPronay
itsPronay merged commit 8163201 into itsPronay:master Oct 24, 2026
1 check passed
@itsPronay

Copy link
Copy Markdown
Owner

Thanks for the PR

@agustux
agustux deleted the fix/theme-selection-cutoff branch October 24, 2026 15:10
@agustux

agustux commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

My pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Padding Issue on Settings view for Theme Selection

2 participants