Skip to content

Stabilize service Helm unit tests for TLS-aware port naming - #55

Merged
Madias2222 merged 2 commits into
mainfrom
copilot/fix-helm-test-job
Jun 19, 2026
Merged

Stabilize service Helm unit tests for TLS-aware port naming#55
Madias2222 merged 2 commits into
mainfrom
copilot/fix-helm-test-job

Conversation

Copilot AI commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

The helm-test Actions job failed because service_test.yaml assumed spec.ports[0].name was always http, while chart behavior now renders https when useTLS is enabled. This PR makes the affected assertions explicit and deterministic.

  • Problem alignment

    • The failure was isolated to charts/iap/tests/service_test.yaml assertions on port name.
    • Tests were implicitly inheriting TLS defaults from shared test values.
  • Changes

    • Added useTLS: false to the specific service test cases that assert spec.ports[0].name: "http".
    • Scope is limited to test inputs; no template/runtime chart logic changed.
  • Why this is the minimal fix

    • Preserves TLS-aware service behavior introduced in the chart.
    • Removes hidden coupling to shared defaults in test data.
# charts/iap/tests/service_test.yaml
set:
  service:
    name: "http-service"
    type: "ClusterIP"
    port: 80
  applicationPort: 80
  useTLS: false
  useWebSockets: false
asserts:
  - equal:
      path: spec.ports[0].name
      value: "http"

Copilot AI changed the title [WIP] Fix failing GitHub Actions job helm-test Stabilize service Helm unit tests for TLS-aware port naming Jun 19, 2026
Copilot AI requested a review from Madias2222 June 19, 2026 13:13
@Madias2222
Madias2222 marked this pull request as ready for review June 19, 2026 13:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to stabilize Helm unit tests for the charts/iap Service template by making TLS-related inputs explicit in test cases that assert a specific port name.

Changes:

  • Adds useTLS: false to several service_test.yaml test cases to avoid inheriting TLS defaults from shared test values.
  • Keeps assertions deterministic for tests that expect spec.ports[0].name: "http".

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread charts/iap/tests/service_test.yaml
Comment thread charts/iap/tests/service_test.yaml
Comment thread charts/iap/tests/service_test.yaml
@Madias2222
Madias2222 merged commit 4dcfe3b into main Jun 19, 2026
4 of 5 checks passed
Copilot stopped work on behalf of Madias2222 due to an error June 19, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants