Stabilize service Helm unit tests for TLS-aware port naming - #55
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job helm-test
Stabilize service Helm unit tests for TLS-aware port naming
Jun 19, 2026
Madias2222
requested review from
Nick-Andreano,
Copilot and
steven-schattenberg-itential
June 19, 2026 13:18
Madias2222
marked this pull request as ready for review
June 19, 2026 13:18
There was a problem hiding this comment.
Pull request overview
This PR aims to stabilize Helm unit tests for the charts/iap Service template by making TLS-related inputs explicit in test cases that assert a specific port name.
Changes:
- Adds
useTLS: falseto severalservice_test.yamltest cases to avoid inheriting TLS defaults from shared test values. - Keeps assertions deterministic for tests that expect
spec.ports[0].name: "http".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
steven-schattenberg-itential
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
helm-testActions job failed becauseservice_test.yamlassumedspec.ports[0].namewas alwayshttp, while chart behavior now rendershttpswhenuseTLSis enabled. This PR makes the affected assertions explicit and deterministic.Problem alignment
charts/iap/tests/service_test.yamlassertions on port name.Changes
useTLS: falseto the specific service test cases that assertspec.ports[0].name: "http".Why this is the minimal fix