Skip to content

chore(sync): merge upstream main through 01a8db0a - #32

Merged
eyeveil merged 49 commits into
mainfrom
sync/upstream-main-20261105
Nov 5, 2026
Merged

eyeveil merged 49 commits into
mainfrom
sync/upstream-main-20261105

Conversation

@eyeveil

@eyeveil eyeveil commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Why

The fork was 47 commits behind upstream main. Among them is request_secret (pingdotgg#30257), which last sync left out. This merges upstream through 01a8db0a with a merge commit, like #31.

What changed

  • Upstream's 47 commits, including request_secret and the move from tsc-rs to the effect-tsgo checker.
  • Four conflicts resolved toward fork behavior. The composer's flash highlight now registers through its own small extension, because upstream removed the marker extension it lived in.
  • Fork-only code fixed for upstream's stricter types. Preview downloads map copy errors to PreviewOperationError, and CoordinationResultDeferred is now a Schema.TaggedError. Home's sidebar row shows upstream's new preparing status as working, and web dictation uses VoiceTranscriptionError's object constructor.

Scope

  • Covers upstream main only. The carried upstream PRs are unchanged.
  • The merge to main uses [skip ci]. The nightly is cut afterwards with a manual Fork Release run.

Blast Radius

Server, web, desktop, and mobile all take upstream changes. The composer editor and the effect worker's retry for deferred coordination results are where fork code changed.

Verification

  • The first CI run caught two web type errors that a partial local typecheck missed. After the fix, web, mobile, desktop, server, and client-runtime typecheck clean on nixbox.
  • The EffectWorker, AgentContextBudget, SecretRequests, and MCP activity tests pass. The measured context budget is below fork main's.
  • Browser tests and one WSL cache test can't run on nixbox, which lacks Playwright browsers and fuser. The WSL test fails the same way with upstream's own file. CI covers both.

Model and harness: Claude Opus 5.5 (merge, conflict resolution, verification) via Claude Code in T3 Code.

gabrielelpidio and others added 30 commits November 4, 2026 09:50
…tgg#30256)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…f chat (pingdotgg#30257)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#30501)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#30523)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…intSigner (pingdotgg#30529)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…bile (pingdotgg#30540)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…he git-read timeout (pingdotgg#30554)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#30900)

Co-authored-by: Victor Romo <vic@Victors-MacBook-Pro.local>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Seth Dixon <333797056+seth-dixon@users.noreply.github.com>
…ord (pingdotgg#30308)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…wser limit is full (pingdotgg#24186)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pingdotgg#26806)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gg#30744)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…0085)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gdotgg#28622)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#29044)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ders (pingdotgg#24904)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…0421)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Elliot Drel <elliotdrel@gmail.com>
…gg#28928)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…dotgg#30704)

Co-authored-by: Maxime Cathala <84846651+mcathala@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
shivamhwp and others added 18 commits November 5, 2026 06:54
…onnection in a loop (pingdotgg#23758)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
… it (pingdotgg#24946)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…7935)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…otgg#26464)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Albert Li <albertli_042@hotmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…wake (pingdotgg#28204)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…29838)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#25341)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…ironment disconnects (pingdotgg#31269)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pingdotgg#29639)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…ve Error (pingdotgg#31216)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Brings in the 47 upstream commits after 8b44f42, including
request_secret (pingdotgg#30257) and the move to the effect-tsgo checker.

Conflicts resolved:
- ComposerPromptEditorTiptap: upstream replaced the marker plugin with
  its Markdown source extension. The fork's composer flash plugin now
  registers through its own ComposerFlashExtension on every editor.
- client-runtime orchestration: merged both import lists.
- agentContextBudget.json: set to the measured fork values, all below
  fork main's committed budget.
- pnpm-lock.yaml: took upstream's and reinstalled to restore the fork's
  patch entries.

Fixes for upstream's stricter checker in fork-only code:
- Desktop preview downloads map copy failures to PreviewOperationError.
- CoordinationResultDeferred is a Schema.TaggedError, checked with
  Schema.is in the effect worker.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Nov 5, 2026
@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[High impact] The sync reaches user workflows across server, web, desktop, and mobile.

The PR appears safe to merge with a non-blocking iOS gallery dismissal issue.

Findings

  1. P2 Gallery closes after swiping ▶
Fix with agent prompt
### Issue 1
apps/mobile/modules/t3-native-controls/ios/T3NativeFilePresentation.swift:188-191
The new loading page lets the user swipe away before the opening image finishes, but `failed` still compares against the original `selectedIndex`. If that image later fails, `dismiss()` closes the whole gallery, even while the user views another image that loaded successfully.

Once the gallery is open, mark the failed page instead of dismissing it. Apply the same change to the selected-image error branch in `FilePreviewModal.tsx`.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Syncs upstream changes across the server, web, desktop, mobile, and relay.

  • Styled text shows editable Markdown markers when the cursor is on it.
  • Pull-request task checkboxes update the description draft.
  • MCP app requests report when a provider session has stopped.
  • Web and mobile cloud connections create DPoP proofs through shared signing logic.
  • The workspace uses effect-tsgo for TypeScript checks.

Reviews (1) · Last reviewed commit: "Merge upstream pingdotgg/t3code main thr..." · Reviewed by Greptile

Comment on lines +188 to +191
guard index != selectedIndex else {
openError = error
dismiss()
return

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Gallery closes after swiping

The new loading page lets the user swipe away before the opening image finishes, but failed still compares against the original selectedIndex. If that image later fails, dismiss() closes the whole gallery, even while the user views another image that loaded successfully.

Once the gallery is open, mark the failed page instead of dismissing it. Apply the same change to the selected-image error branch in FilePreviewModal.tsx.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/mobile/modules/t3-native-controls/ios/T3NativeFilePresentation.swift
Line: 188-191

Comment:
**Gallery closes after swiping**

The new loading page lets the user swipe away before the opening image finishes, but `failed` still compares against the original `selectedIndex`. If that image later fails, `dismiss()` closes the whole gallery, even while the user views another image that loaded successfully.

Once the gallery is open, mark the failed page instead of dismissing it. Apply the same change to the selected-image error branch in `FilePreviewModal.tsx`.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Written by claude-opus-5-5 on behalf of eyeveil

This file matches upstream main byte for byte. The gallery came in with this sync, and the fork has no changes to it or to FilePreviewModal.tsx. The case you describe, where the first image fails after the user swipes to another page, would close the gallery. It is worth fixing upstream. This sync leaves it as is so the fork does not diverge on a file it doesn't own.

Home's sidebar row shows the new preparing status as working, and web
dictation builds VoiceTranscriptionError with its object constructor.
@eyeveil
eyeveil merged commit 09ce8c4 into main Nov 5, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants