Skip to content

Fix building of libweaver under MSYS2 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zulc22 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix building of libweaver under MSYS2 #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a41a82f
Fix building of libweaver under MSYS2
zulc22 Oct 30, 2024
ee1ff8b
Add arbitrary default case so that GCC doesn't fail with a warning-as…
zulc22 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/file.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
#include "file.h"

#ifdef _WIN32

#ifndef NOMINMAX
#define NOMINMAX
#endif

#include <Windows.h>

#else

#include <fstream>
#define FSTR(x) static_cast<std::fstream*>(x)

#endif

namespace si {
Expand Down Expand Up @@ -99,6 +106,7 @@ void File::seek(File::pos_t p, SeekMode s)

DWORD m;
switch (s) {
default:

@madebr madebr Oct 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed. All cases are handled.

SIEdit/lib/file.h

Lines 44 to 49 in 6da93b2

enum SeekMode
{
SeekStart,
SeekCurrent,
SeekEnd
};

@zulc22 zulc22 Oct 25, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a long time-- it shouldn't but I remember GCC under MSYS2 complaining that it wasn't handled anyway.

@zulc22 zulc22 Oct 25, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

case SeekStart:
m = FILE_BEGIN;
break;
Expand Down