Repository navigation
Conversation
…he wrong entity
- FilterItem now takes the tree position as `itemId` and the saved filter id as `id`.
Delete used the "group/index" tree id, so it requested DELETE /v1/filter/1/1, which
404s ("Something went wrong"; locally a CORS preflight error).
- SideBar deletes against `filterEntity` when the list has one, the same as saving.
The reload after deleting an invoice filter asked for AbstractInvoice, came back
empty, and dropped the whole Custom Filters group.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… connected side bar children The delete button is visibility: hidden until hover, so role queries need hidden: true. Importing SideBar on its own loaded constants/Config through ChecklistsFilters and hit an import cycle back into the list view; the connected children are mocked instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… by its aria-label A visibility: hidden element has an empty accessible name, so a role query filtered by name never matches it, hidden: true or not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude reviewJira: CS-633. The Jira lookup isn't available in this run, so I didn't check the change against the ticket in this pass. Reviewed range: Assessment: The only change in this range is a merge of No issues found. Reviewed up to e79ada4 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CS-633: deleting a custom filter shows "Something went wrong".
Summary
Two bugs on the same delete path in the list view side bar:
"group/index") was also used as the filter id, so delete requestedDELETE /v1/filter/1/1. That returns 404 ("Something went wrong"; against a local dev server it shows up as a CORS preflight failure).Invoice(filterEntity) but deleted underAbstractInvoice. The reload after the delete came back empty and removed the whole Custom Filters group until a page refresh.Evidence
OPTIONS/GET /a/v1/filter/1/1?entity=AbstractInvoice→404. Local DB has filters saved underInvoiceonly (none underAbstractInvoice), so the post-delete reload returned[].After: the request goes to
/a/v1/filter/{id}(preflight200), and the reload usesInvoice.client-html/src/tests/list-view/):filterItemIds.test.tsx: clicking delete on the 2nd filter of group 1 →deleteFilter(7, …), not"1/1".sideBarDeleteFilter.test.tsx: invoice list →deleteFilter(312, 'Invoice', …); nofilterEntity→'AbstractInvoice'.tsc --noEmitpasses; ESLint clean on changed sources. Jest runs in CI.Merge Danger
Door: two-way
Blast Radius: small
Client only: custom filter delete in the list view side bar and the timetable custom filters, which share
FilterGroup. Tree item ids and selection are unchanged.🤖 Generated with Claude Code