Repository navigation
CS-553 fix: DataCollectionForm component test for the toggle-button switches - #1582
Merged
Merged
Conversation
…witches The tutor visibility styling commit replaced the labelled Mandatory and Visible to tutors switches with ToogleCheckbox, whose checkbox is hidden and unlabelled. Find each toggle by its checked-side button text and read the state from the checkbox in the same button group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1575 was merged while its
client-testswere still running, and they failed. Its last commit (273b7af) replaced the labelled switches withToogleCheckbox, whose checkbox is hidden and has no label, so the test's label lookup found nothing.mainonly runs server tests on push, so the failure will show up on the next onCourse PR.Only the test changes. It still asserts one toggle per field and that the number checked matches the mock data.
Evidence
DataCollectionForm.Components.test.tsxfails onmain(CI run on 9e4827b486, reproduced locally):TestingLibraryElementError: Unable to find a label with the text of: MandatoryAfter:
✓ DataCollectionForm components should render with given values(run locally, this test file only)ToogleCheckboxmakes the test fail (Expected length: 2, Received length: 1).Merge Danger
Door: two-way
Blast Radius: none. Test-only change, no production code touched.
🤖 Generated with Claude Code