Repository navigation
SST-258 Updated user invitation email text and bold formatting - #1578
Merged
Merged
Conversation
Invitation email is now sent as HTML with bold "Accept your invitation and set your password:" and "Please note:" labels and clickable links. Added GetEmailHtmlBody.valueOf(String) to support a raw HTML body. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Unit Test Results 86 files + 85 86 suites - 153 5m 20s ⏱️ - 4m 51s Results for commit d9a858b. ± Comparison against base commit 48f80c6. This pull request removes 258 and adds 446 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new-user invitation email has the new wording and is now sent as HTML. "Accept your invitation and set your password:" and "Please note:" are bold, and both links can be clicked.
GetEmailHtmlBodygets avalueOf(String)factory, so a raw HTML body can be passed in. Until now, HTML bodies only came from email templates or saved messages.The old first line named the person who sent the invite (" has given you access…"). The new wording doesn't, so
currentUseris no longer used in the email body; the method signature is unchanged.Evidence
MailDeliveryService→Transport.sendto a local fakeSMTP server, which received:UserFunctionsTestpasses: it sends with SMTP in mock mode, then checks the subject, sender and recipient, that the message has a singletext/htmlpart, and that both bold labels and links are present.Merge Danger
Door: two-way
Blast Radius: invitation-emails
Only the new-user invitation email (from the Users screen and the first-start admin invite) changes. Because the email is HTML-only, with no plain-text fallback, clients that display only plain text will see raw tags. Template-based emails already behave the same way, since
GetContentsends HTML alone whenever an HTML body exists.🤖 Generated with Claude Code