Skip to content

SST-258 Updated user invitation email text and bold formatting - #1578

Merged
yuryyas merged 2 commits into
mainfrom
SST-258_Invitation_email_text_and_formatting
Nov 16, 2026
Merged

yuryyas merged 2 commits into
mainfrom
SST-258_Invitation_email_text_and_formatting

Conversation

@yuryyas

@yuryyas yuryyas commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

The new-user invitation email has the new wording and is now sent as HTML. "Accept your invitation and set your password:" and "Please note:" are bold, and both links can be clicked.

 sendInvitationEmailToNewSystemUser
-  SmtpParameters(plain text)
-  MailDeliveryParamBuilder.valueOf(parameters).build()
+  MailDeliveryParam.valueOf(..., GetContent(GetEmailHtmlBody.valueOf(buildInvitationEmailHtml(serverAddress, token))))
   mailDeliveryService.sendEmail(param)

GetEmailHtmlBody gets a valueOf(String) factory, so a raw HTML body can be passed in. Until now, HTML bodies only came from email templates or saved messages.

The old first line named the person who sent the invite (" has given you access…"). The new wording doesn't, so currentUser is no longer used in the email body; the method signature is unchanged.

Evidence

  • Before: plain-text email with no formatting:
    John Smith has given you access to the ish onCourse application for https://… . Please click here to accept this invitation.
    https://…/invite/<token>
    This invitation will expire in 7 days.
    
    After: sent through the real MailDeliveryService → Transport.send to a local fakeSMTP server, which received:
    Content-Type: text/html; charset=us-ascii
    
    <p>You have been invited to access the ish onCourse application.</p>
    <p>To accept your invitation and set up your password, please click the link below:</p>
    <p><b>Accept your invitation and set your password:</b> <a href="https://test.cloud.oncourse.cc/invite/<token>">https://test.cloud.oncourse.cc/invite/<token></a></p>
    <p>Once you've completed this step, you can access ish onCourse at: <a href="https://test.cloud.oncourse.cc">https://test.cloud.oncourse.cc</a></p>
    <p><b>Please note:</b> This invitation will expire in 7 days. Make sure you accept it and set your password before then.</p>
    <p>Welcome aboard</p>
  • New UserFunctionsTest passes: it sends with SMTP in mock mode, then checks the subject, sender and recipient, that the message has a single text/html part, and that both bold labels and links are present.

Merge Danger

Door: two-way

Blast Radius: invitation-emails

Only the new-user invitation email (from the Users screen and the first-start admin invite) changes. Because the email is HTML-only, with no plain-text fallback, clients that display only plain text will see raw tags. Template-based emails already behave the same way, since GetContent sends HTML alone whenever an HTML body exists.

🤖 Generated with Claude Code

Invitation email is now sent as HTML with bold "Accept your invitation
and set your password:" and "Please note:" labels and clickable links.
Added GetEmailHtmlBody.valueOf(String) to support a raw HTML body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Unit Test Results

  86 files  +  85    86 suites   - 153   5m 20s ⏱️ - 4m 51s
446 tests +188  436 ✔️ +178  10 💤 +10  0 ❌ ±0 
452 runs  +194  442 ✔️ +184  10 💤 +10  0 ❌ ±0 

Results for commit d9a858b. ± Comparison against base commit 48f80c6.

This pull request removes 258 and adds 446 tests. Note that renamed tests count towards both.
 a reload restores the selection to the group it was made in, not to every group holding it ‑  a reload restores the selection to the group it was made in, not to every group holding it
 a tick in one group is not shown in another group built from the same tags ‑  a tick in one group is not shown in another group built from the same tags
 an url written before the group was recorded still ticks the tags it names ‑  an url written before the group was recorded still ticks the tags it names
 bare ids belong to the unnamed group once the url names any group at all ‑  bare ids belong to the unnamed group once the url names any group at all
 every ancestor of a selection is expanded, so no parent is read as a childless leaf ‑  every ancestor of a selection is expanded, so no parent is read as a childless leaf
 one child ticked: parent stays indeterminate across a reload ‑  one child ticked: parent stays indeterminate across a reload
 reuses no item id across two live filter items ‑  reuses no item id across two live filter items
 the stored selection does not grow when the tree view reports its own mounting ‑  the stored selection does not grow when the tree view reports its own mounting
 the url names the group a tag was ticked in ‑  the url names the group a tag was ticked in
 ticking a collapsed tag selects the children it has not mounted yet ‑  ticking a collapsed tag selects the children it has not mounted yet
…
ish.budget.ClassBudgetUtilTest ‑ testGetClassCostExTax()
ish.budget.ClassBudgetUtilTest ‑ testGetClassIncomeExTax()
ish.budget.ClassBudgetUtilTest ‑ testGetClassProfitExTax()
ish.budget.ClassBudgetUtilTest ‑ testGetClassRunningCostsExTax()
ish.budget.ClassCostUtilTest ‑ testActualCostDiscount()
ish.budget.ClassCostUtilTest ‑ testApplyOnCostRateAndMinMaxCost()
ish.budget.ClassCostUtilTest ‑ testBudgetedCostDiscount()
ish.budget.ClassCostUtilTest ‑ testGetActualCost_DISCOUNT()
ish.budget.ClassCostUtilTest ‑ testGetActualCost_FIXED()
ish.budget.ClassCostUtilTest ‑ testGetActualCost_PER_ENROLMENT()
…

♻️ This comment has been updated with latest results.

@yuryyas
yuryyas merged commit 5805408 into main Nov 16, 2026
4 checks passed
@yuryyas
yuryyas deleted the SST-258_Invitation_email_text_and_formatting branch November 16, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant