Repository navigation
fix: stop clearStorageData waiting on hidden views' web processes - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a macOS hang where
session.clearStorageData()could stall for 15 seconds and then reject. It also fixes the flakysession.clearStorageDatatest that has been failing CI and local pushes intermittently.Root cause
clearStorageDataasked WebKit to remove every data type, includingWKWebsiteDataTypeMemoryCache.WebsiteDataStore::removeData started, then only 4 of 6 web processes replied, andfinished deletingnever appears. In healthy runs it appears 6-15 ms afterstarted.clearStorageDatawhile one of its windows is hidden (a tray app is the common case) on a loaded machine.Fix
Remove every type except the in-process memory cache. Electron's
clearStorageDatadoesn't clear the renderer's memory cache either. The trade-off: open pages keep their in-memory cached resources until they reload. That is now documented on the session API page.Tests
SIGSTOPto simulate the starved process deterministically.bun run validateexits 0 (1902 pass, 185 skip, 0 fail).🤖 Generated with Claude Code