Skip to content

Beta review: fix review findings, platform seam, release 0.1.0-alpha.9 - #27

Merged
ipfizz merged 611 commits into
mainfrom
chore/beta-review
Sep 28, 2026
Merged

ipfizz merged 611 commits into
mainfrom
chore/beta-review

Conversation

@ipfizz

@ipfizz ipfizz commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

The pre-beta review, released as 0.1.0-alpha.9. We read the whole repo line by line in 24 slices and got 669 findings. Each finding was re-checked with a failing test before it was fixed. This PR is those fixes in small commits. Its last commit is the release commit.

What changed

  • Review fixes: about 320 findings fixed, each with a test; about 180 skipped with a written reason (wrong, already fixed, or a documented D0xx deviation). Follow-up waves then took on fixes that cross slices, a docs-versus-code pass, and the leftovers.
  • Criticals:
    • Packaged apps find their package.json, so name, version and userData are the app's own.
    • The Windows updater no longer puts manifest fields into a shell command.
    • build no longer ships the update-signing private key.
  • macOS leak: every closed window leaked its NSWindow, WKWebView and web process. The cause was no autorelease pool outside the run-loop drain. A rolling pool between ticks fixes it, plus guards on every window and webContents method after close.
  • Electron quit semantics:
    • app.quit() runs before-quit, closes every window (a veto cancels), then will-quit and quit(event, code).
    • Cmd+Q, Dock Quit and logout take the same path.
    • The quit role works on Linux and Windows.
  • Platform seam:
    • The backend contracts live in platform/services.ts.
    • Each OS backend is picked through one service table in platform/index.ts.
    • The injected scripts are built once in platform/web-scripts.ts.
    • A biome noRestrictedImports rule enforces D024: api/ never imports a concrete backend, and backends never import api/.
  • Leftovers:
    • A built app's getName() matches dev.
    • Linux dom-ready runs in the isolated world only.
    • Native images are released on all three OSes.
    • Linux notifications, trays and sleep inhibitors carry the app's name.
    • Windows and D-Bus callback throws surface as uncaught exceptions.
    • Numpad and Insert shortcuts work.
    • The .deb declares minimum GTK and WebKitGTK versions.
  • Linux regression caught by CI: the menu-bar box left the webview at its natural height, which is 0, so windows came up blank. The webview now expands to fill the box.
  • Comments and docs:
    • Comments were trimmed to the 13 CONTRIBUTING rules, and em dashes removed repo-wide.
    • Every API page was re-checked against the code.
    • The changelog and roadmap are updated for alpha.9.

Checks

  • macOS: bun run validate exit 0, 1901 pass / 185 skip / 0 fail. The website gate is green.
  • CI at 9e2e312 is green on macOS, Linux (1730/189) and Windows-scoped (231/15). The test budgets are ratcheted to those counts.
  • Skips rose because 79 Windows integration tests are now counted with describe.skipIf, where they used to silently not register.
  • Known intermittent: the macOS session.clearStorageData test. It normally finishes in 5-13 ms. It hung for the full 15 s in one ten-minute window, then passed 13 full runs in a row. The details are in the internal status notes.

Release

Merge with a merge commit, not a squash, so the per-finding history survives. Then wait for main CI to be green, tag v0.1.0-alpha.9, and run npm publish from macOS.

🤖 Generated with Claude Code

@ipfizz ipfizz changed the title Beta review: fix review findings, trim comments, Electron quit semantics Beta review: fix review findings, platform seam, release 0.1.0-alpha.9 Sep 28, 2026
@ipfizz
ipfizz marked this pull request as ready for review September 28, 2026 21:04
@ipfizz
ipfizz merged commit 6c4e55c into main Sep 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant