Repository navigation
fix(ios): silence Swift build warnings - #130
Open
shivapoudel wants to merge 1 commit into
Open
shivapoudel wants to merge 1 commit into
shivapoudel wants to merge 1 commit into
Conversation
- Declare the Decodable conformances of OSIABDismissStyle, OSIABViewStyle, OSIABAnimationEffect and OSIABToolbarPosition as @retroactive: the types come from OSInAppBrowserLib. - Capture self weakly in the DispatchQueue.main.async closures, which already use [weak self] in the closures nested inside them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the plugin with Xcode 26 gives 11 warnings from this package:
LibraryModels+Decodable.swift. The types come fromOSInAppBrowserLib, so the conformances are marked@retroactive. This needs a Swift 5.10+ compiler (Xcode 15.3+); the package'sswift-tools-versionis 5.9, so say if you would rather gate it.InAppBrowserPlugin.swift: theDispatchQueue.main.asyncclosures that holdselfstrongly while the closures inside them use[weak self]. They now captureselfweakly too.No behaviour change. We apply the same diff as a pnpm patch in our app and a clean build shows none of these warnings.
🤖 Generated with Claude Code