Repository navigation
fix(wal): read the log and replay refs through the caller's manifest - #9
Merged
Merged
Conversation
catch_up took head_seq from one manifest while read_log resolved a fresher one; a checkpoint in between trims that one's segments, so the bridge emitted nothing and advanced its cursor past the push. read_log, refs_at_seq, refs_as_of and the checkpoint-time helpers now take the caller's manifest, and fresh_manifest() is the explicit way to get the newest one. Round trips: the bridge catch-up, the settings history and policy dry-run, the repository overview and `walgit settings history` each made two conditional manifest GETs (the sync, then read_log's own) and now make one; `walgit wal ls` and `wal show` still make one. No budget in docs/ROUNDTRIPS.md changes.
# Conflicts: # crates/walgit-server/tests/events.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge
fork-events-foldmergeswt-events-fold(the upstream PR's branch, based on upstreammain80e9a20) into this fork'smain; the one conflict, both sides appending tests totests/events.rs, keeps both. On the merged treejust clippy,just simandjust e2epass;just testpasses except the three asset tests that needpnpm run build, which fail the same way without this change.