[_] feature/Upload manually asset action#536
Open
CandelR wants to merge 2 commits into
Open
Conversation
…, rather than during the copy cycle
|
larryrider
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upload the asset immediately when the "Backup" button is pressed, instead of queueing it into the automatic backup cycle
Summary
thunks/upload.ts: addeduploadAssetsManuallyThunkindependent ofrunUploadThunkPhotoUploadQueue.ts: added tostart()an optionalexternalSignalparam so a manual upload uses its ownAbortController, decoupled from the automatic cycle's in order to paused/aborted cycle can no longer cancel a manual upload in progressPhotoActionsService.ts: removedrestoreToCloud, superseded byuploadAssetsManuallyThunk, it no longer did anything useful.usePhotoActionHandlers.ts:handleRestoredispatchesuploadAssetsManuallyThunkwith its own throwaway signal, not the shared action abort ref, so closing the preview during upload doesn't cancel it.usePreviewItems.ts: newmarkAssetBackedUp. The preview receives its items as a frozen snapshot that never re-syncs with Redux or DB while open, so this locally flags a uploaded item as backed to reflect state we already know, without waiting for the user to leave and re-open the preview.PhotoPreviewScreen/index.tsx:isCloudDeleted/isSyncednow derived fromuseLiveBackupStatusinstead of the frozen snapshot.useLiveBackupStatus.ts,usePhotoActions.ts: minor adjustments to keep automatic backup cycle completion tracking untouched by the manual path.