Handle missing contacts in contact update action serialization#2934
Open
maricavor wants to merge 1 commit into
Open
Handle missing contacts in contact update action serialization#2934maricavor wants to merge 1 commit into
maricavor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NoMethodError (undefined method 'code' for nil:NilClass)inAction#serialized_contactwhen serializing contact update notifications/repp/v1/registrar/summaryreturned 500, causing a redirect loop (too_many_redirects) in the frontendContactUpdateActionnotification where the action or one of its bulk subactions had a nilcontact(likely from a registrant auto-update where contact save failed or contact was removed)Action#to_non_available_contact_codesnow skips nil contacts instead of crashing; affected endpoints return an empty contacts list for the broken entries