Repository navigation
feat: add resource definitions for all packages - #51
Merged
Merged
Conversation
Contributor
|
@ritoban23 you forgot to update the chart version :) Can you please also bump the patch version of the chart? Thank you |
- rafiki-auth: 0.4.3 -> 0.4.4 - rafiki-backend: 0.4.4 -> 0.4.5 - rafiki-frontend: 0.4.3 -> 0.4.4
golobitch
approved these changes
Oct 18, 2025
golobitch
left a comment
golobitch
left a comment
Contributor
There was a problem hiding this comment.
@ritoban23 looks good. Thank you for this contribution. Much appreciated!
|
Hi @ritoban23 , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Define resources for all packages
Addresses issue #29 by adding Kubernetes resource definitions to prevent unlimited resource consumption.
📋 Changes Made
Resource definitions added to all charts:
Files modified:
charts/rafiki-auth/values.yaml&templates/deployment.yamlcharts/rafiki-backend/values.yaml&templates/deployment.yamlcharts/rafiki-frontend/values.yaml✅ Validation
🔗 Issue
Closes #29