Skip to content

Cancelled backups and uploads leave truncated .img.xz files that cannot be deleted from the UI #153

Description

@eliasbakken

Found testing v1.1.0-RC8-2-g23a2bb6 on A8 s/n 0498.

What happens

After cancelling operations, truncated images stay in the install list on the USB drive:

operation left behind
Backup claude-backup-test, cancelled at 3% claude-backup-test.img.xz, 60 751 872 B
File upload, cancelled at 75% claude-cancel-test.img.xz, 235 929 600 B

The integrity check does its job: selecting either gives the red X and Install stays disabled. But the files stay forever, taking space, and the UI has no way to remove them.

Backup: a plain bug

cancelBackup does os.Remove(images_folder + "/" + state.Filename), i.e. .../claude-backup-test. backup-emmc writes ${OUTFILE}.img.xz. The remove targets a file that never exists.

Upload

uploadCancel never removes the partial file. Maybe that is deliberate (#118 relies on the integrity check), but then there needs to be a delete.

Also

  • After the backup cancel, the open tab's image list did not show the new partial file until a reload.
  • Suggest: delete partial files on cancel in both paths, and add a delete action for images in the list.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions