fix(file-manager): Lua file upload — shortify + minify on save, expand on read - #1580
Open
kkerti wants to merge 2 commits into
Open
fix(file-manager): Lua file upload — shortify + minify on save, expand on read#1580kkerti wants to merge 2 commits into
kkerti wants to merge 2 commits into
Conversation
The editor tagged .lua files "intech_lua" but the transform gates compared "lua", so they were dead: human-readable Grid API names were written to modules verbatim (nil at runtime) and device files shown without expanding. Route .lua save through GridScript.compressScript (shortify + minify — compact storage for memory-constrained flash) and read through expandScript (humanize + beautify). Language id centralized so the map and gates can't drift again. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
TEST: copying human readable function names with sequencer project works now, we should still do focused test with @Greg-Orca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file manager tagged
.luafiles asintech_lua, but the save/read transforms comparedselectedLanguage === "lua"— never true. So human-readable Grid API names (e.g.draw_rectangle_filled) were uploaded to modules verbatim and failed at runtime (attempt to call a nil value), and device files were shown without expanding.Fix: route
.luasave throughGridScript.compressScript(shortify + minify — compact storage for memory-constrained flash) and read throughGridScript.expandScript(humanize + beautify) — the same pipeline the runtime uses to send code to a module. The language id is centralized in one constant so the language map and the transform gates can't drift apart again.🤖 Generated with Claude Code