Repository navigation
1.4.0: compact row actions and a progress bar for narrow layouts - #33
Merged
rickypid merged 2 commits intoOct 24, 2026
Merged
Conversation
Make the activities list usable on tablets (compact actions, minimum width, "more" menu) and add a progress line to the cells, with readable titles and resize edges that follow the cell color. See CHANGELOG 1.4.0 for the details.
Add test/cell_progress_and_edges_test.dart (resize edges on cut sides, progress track and line inset and measured on the whole activity, the "more" menu tooltip assert) and two GanttController tests for removeAllFetchListener and dispose with a mounted Gantt. Show progress and the narrow layout options in the example. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Thanks @a-nisi-insideapp! These changes shipped together with #34 in a single 1.4.0 release: both commits were merged with their original authorship and you're credited as co-author in the CHANGELOG and in the merge commit. As agreed, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Makes the activities list usable on narrow layouts and adds a progress indicator to the default cell:
cellHeightrow actions,Gantt.activitiesListMinWidth,Gantt.collapseActionsBelowWidth(a "more" menu that uses the action tooltips as labels) andGanttTheme.listIndent;GanttActivity.progress/progressColor: a line over a track along the bottom of the cell, inset like the title and measured on the whole activity, so it continues beyond the grid edge on a cut side;Ganttfollows a newtheme(didUpdateWidget),GanttThemevalue equality,GanttController.setTheme(theme, {notify});GanttController.removeAllFetchListener()/dispose()throwing aConcurrentModificationErrorwhen a fetch listener was still registered.Version bumped to 1.4.0; see CHANGELOG 1.4.0 for the details. README updated with the new
Ganttproperties andGanttActivity.progress.Why is it needed?
On tablets the 40/48px action buttons left almost no room for the titles, which were cut to one or two characters, and the status icons ended up under the edit button. fix #32
How to test it?
Run the example: some activities now have a progress line (0%, 30%, 60%, above 100%, and a long task cut by the visible range), the list keeps a minimum width, and narrowing the window groups the actions of "Main Task" in the "more" menu. Switching the app theme updates the chart.
flutter testcovers the color helpers (test/color_test.dart), the progress bar and resize edges (test/cell_progress_and_edges_test.dart) and the controller dispose (test/gantt_controller_fetch_test.dart).Related issues/PRs
fix #32
Ready to be merged.
🤖 Generated with Claude Code