Skip to content

Correct TCR comparison logic - #50

Merged
mvcowley merged 13 commits into
masterfrom
fix-lev-distance
Mar 20, 2026
Merged

mvcowley merged 13 commits into
masterfrom
fix-lev-distance

Conversation

@mvcowley

@mvcowley mvcowley commented Mar 10, 2026 •

Copy link
Copy Markdown
Member

This PR resolves a logic error when comparing TCR sequences in the read_in_data function. This function called are_seqs_equivalent(), but incorrectly passed a percentage rather than a fraction.

The usage of fractions rather than percentages has been standardised across the code, with the conversion happening a single time in the main function body, and variable names clarified to clearly indicate when the threshold is in either form.

The input argument is still a percentage to avoid a breaking change.

@mvcowley
mvcowley requested a review from bchain March 10, 2026 15:17
@mvcowley mvcowley self-assigned this Mar 10, 2026
@mvcowley
mvcowley merged commit 465decf into master Mar 20, 2026
4 checks passed
@mvcowley
mvcowley deleted the fix-lev-distance branch March 20, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant