build: Remove unused arguments for PHPUnit#73
Open
theofidry wants to merge 3 commits into
Open
Conversation
Currently executing PHPUnit will generate clover, JUnit and XML coverage reports in `build/logs`, which is should be changed for `var` (see #45). However, I noticed that none of those reports are actually used, neither in the CI, neither by infection (it executes the tests itself). Hence instead of changing the directory this PR removes them entirely.
This reverts commit 3c9a0d7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently executing PHPUnit will generate clover, JUnit and XML coverage reports in
build/logs, which is should be changed forvar(see #45).However, I noticed that none of those reports are actually used,
neither in the CI, neither by infection (it executes the tests itself).Edit: It appears we were relying on the default path for the clover report to update it to Coveralls. I adjusted the path to
varand set the path explicitly.