Relax patch requirements for lmsConfig to allow piecemeal creation - #704
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Relaxes the Directory service PATCH /entries behavior so an lmsConfig can be created incrementally (without requiring address and fromAgency at creation time), aligning with piecemeal configuration workflows.
Changes:
- Removes the
400 Bad Requestvalidation that previously blocked creation of a newlmsConfigunlessaddressandfromAgencywere provided. - Updates the API test case to expect
204 No Contentand validates the refetched entry state for an incompletelmsConfigpatch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
directory/api/entries.go |
Allows lmsConfig upsert to proceed when no existing row is present, only treating non-ErrNoRows query errors as fatal. |
directory/test/entries_test.go |
Adjusts the incomplete lmsConfig PATCH test to expect success and adds a refetch assertion fixture. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kurtnordstrom
marked this pull request as ready for review
August 11, 2026 21:14
kurtnordstrom
requested review from
JanisSaldabols,
adamdickmeiss and
jakub-id
as code owners
August 11, 2026 21:14
jakub-id
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.