Repository navigation
Workouts page: import dialog, header button and page drop - #70
Merged
Merged
Conversation
Pure import dialog view (landing/importing/result/error) with stories and tests. The category select of the workout details dialog is extracted into WorkoutCategorySelect, behaviour unchanged.
Reads the import phase from the page service, refreshes on import-update, routes file/pick-another/category actions to the service and ends the import exactly once on every close path or unmount.
…import cards The import flow now runs in WorkoutImportDialog, opened from a header button or by dropping a file anywhere on the page. The carousel upload/active-import cards and the retry wiring are removed, and the create-info text points at the new button.
…t graph, Import another Result phase shows a success header, a left-aligned category select that always has a value, and the imported workout graph (centred fallback panel when no workout is provided). Title is now Import Successful, an Import another button returns to the landing phase. Importing shows a loader, error shows an error icon above the message.
…n; Dialog keeps a stable key and a dialog stack so ESC reaches the topmost dialog
gdoumen
marked this pull request as ready for review
November 17, 2026 12:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the mobile import-workout UX to the Workouts page.
What changed
WorkoutCategorySelect.Dialogmolecule: each dialog now keeps a stable key and registers on a stack, sowindow.activeDialogalways points at the topmost dialog. Previously a re-render of a lower dialog while an upper one was open could leave a stale key and make Esc stop working. This affects all dialogs.Depends on
The services PR on the same branch name (import flow in the base page service,
onImportFiles, result workout data). Release services first and bump the pinned version here before merging.Test plan