Repository navigation
Web workout attach: explicit workout/route attachment, Workouts page on page service, scheduled-today prompt - #69
Merged
Merged
Conversation
Contributor
Author
|
Added: the Workouts page reads the new |
gdoumen
marked this pull request as ready for review
November 16, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the mobile workout/route attach UX to web-ui. A workout and a route are now attached explicitly and visibly (
Route: <name> [x]/Workout: <name> [x]chips), nothing is selected implicitly, and the Workouts page runs on the new desktop page service instead of calling domain services directly. The Workouts page layout (Scheduled + category carousels with Import and Create cards) is unchanged.Depends on the services PR: incyclist/services#692 (consumed through the dev alias; the
incyclist-servicesversion needs bumping after it is published).What changed
getWorkoutListPageService()+usePageService. It makes no domain-service calls; the screen takes plain lists with per-list and per-card observers, and subscribes with proper cleanup.hasWorkoutflag.onAddWorkoutprop is dropped).AttachmentChipmolecule;Iconatom forwardsaria-label;Dialogemits a close event used to defer the prompt.Behaviour change
Test plan
npm test(unit + story tests)Not yet verified in a running app.