Repository navigation
feat: apps settings as expandable list, aligned with the mobile app - #68
Merged
Merged
Conversation
Replace the logo tiles and the separate settings page per app with a single list: every entry shows the name and the connection status and expands to connect/disconnect and the operations of the app. The list is rendered from the apps provided by the apps service. Strava and Intervals.icu share one OAuthAppSettings component. Komoot keeps its login dialog and uses the same settings view. The operation labels match the mobile app. Remove the app logos that are no longer used from the bundle, and stop logging the user name when connecting.
joaopavila
reviewed
Nov 14, 2026
| onConnect={onConnect} onDisconnect={onDisconnect} | ||
| onOperationsChanged={onOperationsChanged} | ||
| <AppSettingsView {...settings} name='Komoot' isConnecting={connecting} | ||
| onConnect={onConnect} onDisconnect={onDisconnect} |
Collaborator
There was a problem hiding this comment.
If I connect Komoot, disconnect it, then collapse the row, the cleanup calls forEach on undefined. Can we keep the operations array when disconnecting?
| const service = useAppsService() | ||
|
|
||
| const [connecting, setConnecting] = useState(false) | ||
| const [settings, setSettings] = useState(() => service.openAppSettings(appKey)) |
Collaborator
There was a problem hiding this comment.
If I reopen this row before OAuth finishes, the dot turns green but the button still says Connect. Can we refresh the panel when the service reports the connection?
| {iconUrl? <Image src={iconUrl} width='100%'/> : | ||
| <Text text={name}/>} | ||
| <Container> | ||
| <Header role='button' tabIndex={0} aria-expanded={expanded} onClick={() => onClick?.()} onKeyDown={onKeyDown}> |
Collaborator
There was a problem hiding this comment.
Can we use the Button here? It already handles Enter and Space.
- Komoot: keep the operations when disconnecting and do not report any changes on closing if the app was not connected before and is not connected now (connecting and disconnecting within one session threw an error on closing) - OAuth apps: the settings follow the connected/disconnected events of the service, so a connection that finishes while the row was collapsed is shown when it is opened again - the header of an entry is a native button (accordion pattern: aria-expanded, aria-controls, region) instead of a div with key handling, with a visible focus indicator
gdoumen
marked this pull request as ready for review
November 15, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings → Apps now works like in the mobile app: a single list instead of logo tiles with a separate settings page per app.
What changed
OAuthAppSettingscomponent (replacingStravaSettingsandIntervalsSettings). Strava keeps its official connect button. Komoot keeps its login dialog and the syncing of its operations, and uses the same settings view.intervals.png,velo-black.png).Review follow-up
connected/disconnectedevents of the service, so a connection that finishes while the row was collapsed is shown when it is opened again (before: green dot, but the button still said "Connect").<button>(accordion pattern witharia-expanded,aria-controlsand a labelled region) instead of a div with key handling, and a visible focus indicator. It is deliberately not theButtonatom: that is an action button (filled, 3D hover), whereas this is a list row that discloses a section.Notes
iconUrlfrom the apps list and adds TrainingPeaks (draft PR with the same branch name).Test plan
npm test: 812 passed, production build compilesTP_INTEGRATIONenabled, TrainingPeaks appears in the list