Skip to content

feat: add Maps API key info pill to settings (INC-52) - #67

Merged
gdoumen merged 2 commits into
mainfrom
INC-52/byo-maps-api-add-tooltip-to-settings-dialog
Nov 16, 2026
Merged

gdoumen merged 2 commits into
mainfrom
INC-52/byo-maps-api-add-tooltip-to-settings-dialog

Conversation

@joaopavila

Copy link
Copy Markdown
Collaborator

Adds an Info pill beside Maps API Key in Settings → Ride. Clicking it explains why a personal key is required for simulated GPX rides with Street View/Satellite View and left/right side views, and how it reduces pressure on Incyclist's shared free tier allowance. The popup links to the confirmed FAQ section through UrlLink.

The trigger reuses Button and Pill, including interaction logging. The popup supports keyboard activation, link focus, outside dismissal and Escape without closing Settings. Existing key editing, masking, validation, persistence and the setup tutorial remain intact. UrlLink now exposes its actual URL for browser navigation while retaining Electron shell and custom callback behavior.

Related: INC-52.

Validation

  • CI=true npm test: 775 tests passed across 81 files.
  • npm run build: passed; existing browser-externalization and bundle-size warnings remain.
  • Chrome: six scenarios at 1920×1080, 1280×800 and 800×600, with native Popover support and its fallback; verified clicks, Enter/Space, Tab to the link, navigation, Escape, outside dismissal and key validation.
  • Added MapsApiKeyHelp Storybook interaction and regression coverage for button logging and link navigation. Existing Storybook dependency import errors prevented its full runtime verification; visual QA used a temporary production-built page with the real Dialog and RideSettingsView components.
  • Standards and spec reviews completed; all three initial standards findings were addressed, with no remaining findings on either axis.

@gdoumen, please validate the settings help text, FAQ destination and popup interactions.

@joaopavila
joaopavila requested a review from gdoumen as a code owner November 13, 2026 20:54

@gdoumen gdoumen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Thanks

@gdoumen
gdoumen merged commit 66d0f3d into main Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants