Repository navigation
feat: add Maps API key info pill to settings (INC-52) - #67
Merged
gdoumen merged 2 commits intoNov 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an Info pill beside Maps API Key in Settings → Ride. Clicking it explains why a personal key is required for simulated GPX rides with Street View/Satellite View and left/right side views, and how it reduces pressure on Incyclist's shared free tier allowance. The popup links to the confirmed FAQ section through
UrlLink.The trigger reuses
ButtonandPill, including interaction logging. The popup supports keyboard activation, link focus, outside dismissal and Escape without closing Settings. Existing key editing, masking, validation, persistence and the setup tutorial remain intact.UrlLinknow exposes its actual URL for browser navigation while retaining Electron shell and custom callback behavior.Related: INC-52.
Validation
CI=true npm test: 775 tests passed across 81 files.npm run build: passed; existing browser-externalization and bundle-size warnings remain.MapsApiKeyHelpStorybook interaction and regression coverage for button logging and link navigation. Existing Storybook dependency import errors prevented its full runtime verification; visual QA used a temporary production-built page with the realDialogandRideSettingsViewcomponents.@gdoumen, please validate the settings help text, FAQ destination and popup interactions.