Repository navigation
Use shared scheduled-workout prompt service in useScheduledWorkoutPrompt - #489
Merged
Merged
Conversation
|
gdoumen
marked this pull request as ready for review
November 16, 2026 13:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
The scheduled-today prompt logic moved into
incyclist-servicesso desktop/web can share it. The mobile hook is now a thin wrapper around it; behaviour is unchanged.Depends on incyclist/services#692 (adds
getScheduledWorkoutPromptPageService). Theincyclist-servicesversion needs bumping after it is published.What changed
useScheduledWorkoutPromptcalls the shared prompt page service (guard, calendar relay, Yes / Check workouts / No intents). Hook signature and return shape are unchanged;enabled=falsestill makes no service call or subscription.prompt,navigatecalls) are kept; the guard and calendar-id checks now live in the services tests.Test plan
npx jeston hooks/workouts and the Workouts, Routes, Activities and NotImplemented pagesnpx tsc --noEmit,npm run lint(no errors)