Skip to content

feat: render the apps dialog from the list provided by the apps service - #488

Merged
gdoumen merged 4 commits into
mainfrom
feat/trainingpeaks-integration
Nov 15, 2026
Merged

gdoumen merged 4 commits into
mainfrom
feat/trainingpeaks-integration

Conversation

@gdoumen

@gdoumen gdoumen commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The Apps dialog no longer has a hardcoded list of apps. It renders what the apps service returns, so newly supported apps (e.g. TrainingPeaks) appear without an app change.

What changed

  • AppsDialogView renders apps (name, key, connection status) in the order provided by the service. An empty list renders no entries. Komoot still gets its own login panel by key; every other app gets the OAuth settings.
  • OAuthAppSettings uses the name from the service for the title and the connect button ("Connect with "). Strava keeps its official button. OAuthAppKey is now a plain string.
  • The expiration received from the auth-server is passed on to the service together with the other credentials, so all OAuth apps use the same contract.
  • Removed the unused iconUrl and intervals.png.
  • Tests for the list rendering, the generic title/button and the credentials handed to the service.
  • Accessibility of the entries: announced as button with its expanded state and a label that contains the name of the app and its connection state (the status is only shown as colour), chevron hidden from screen readers.

Notes

  • The OAuth settings of an entry read the state of the service once when they are opened and do not follow later changes (e.g. a connection that finishes while the entry was collapsed). That is not changed here, the web-ui has a fix for the same flaw.
  • Depends on the services change (draft PR with the same branch name) for the shared credentials contract and the removal of iconUrl.
  • Strava and Intervals.icu do not receive an expiration from the auth-server, so they pass null as before.

Test plan

  • npx tsc --noEmit, ESLint on the changed components
  • npx jest: 2069 passed
  • Manual: Apps dialog lists all apps from the service, expand/collapse works
  • Manual: connect and disconnect Strava and Intervals.icu; with TP_INTEGRATION enabled, TrainingPeaks is listed and connects

Remove the hardcoded list of apps from the apps dialog. Entries come from the apps service (name, key, connection status), so newly supported apps show up without changes in the app. The OAuth settings use the name provided by the service for the title and the connect button (Strava keeps its official button) and pass the expiration of the access token on to the service, like all other credentials.

Remove the unused iconUrl and intervals.png.
An entry of the apps dialog is announced as button with its state (expanded) and a label that contains the name of the app and its connection state, as the status is only shown as colour. The chevron is hidden from screen readers.
@sonarqubecloud

Copy link
Copy Markdown

@gdoumen
gdoumen marked this pull request as ready for review November 15, 2026 18:32
@gdoumen
gdoumen merged commit a05b442 into main Nov 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant