Repository navigation
feat: render the apps dialog from the list provided by the apps service - #488
Merged
Merged
Conversation
Remove the hardcoded list of apps from the apps dialog. Entries come from the apps service (name, key, connection status), so newly supported apps show up without changes in the app. The OAuth settings use the name provided by the service for the title and the connect button (Strava keeps its official button) and pass the expiration of the access token on to the service, like all other credentials. Remove the unused iconUrl and intervals.png.
An entry of the apps dialog is announced as button with its state (expanded) and a label that contains the name of the app and its connection state, as the status is only shown as colour. The chevron is hidden from screen readers.
|
gdoumen
marked this pull request as ready for review
November 15, 2026 18:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
The Apps dialog no longer has a hardcoded list of apps. It renders what the apps service returns, so newly supported apps (e.g. TrainingPeaks) appear without an app change.
What changed
AppsDialogViewrendersapps(name, key, connection status) in the order provided by the service. An empty list renders no entries. Komoot still gets its own login panel by key; every other app gets the OAuth settings.OAuthAppSettingsuses the name from the service for the title and the connect button ("Connect with "). Strava keeps its official button.OAuthAppKeyis now a plain string.expirationreceived from the auth-server is passed on to the service together with the other credentials, so all OAuth apps use the same contract.iconUrlandintervals.png.Notes
iconUrl.expirationfrom the auth-server, so they passnullas before.Test plan
npx tsc --noEmit, ESLint on the changed componentsnpx jest: 2069 passedTP_INTEGRATIONenabled, TrainingPeaks is listed and connects