Skip to content

Detect heart rate bridged by Wahoo trainers over Direct Connect - #147

Open
friendlyFriend4000 wants to merge 1 commit into
incyclist:mainfrom
friendlyFriend4000:wahoo-bridge-HR-direct-wifi
Open

friendlyFriend4000 wants to merge 1 commit into
incyclist:mainfrom
friendlyFriend4000:wahoo-bridge-HR-direct-wifi

Conversation

@friendlyFriend4000

@friendlyFriend4000 friendlyFriend4000 commented Nov 9, 2026 •

Copy link
Copy Markdown

Summary

When a Wahoo KICKR CORE 2 trainer is connected over WiFi (Direct Connect) with a heart rate strap paired to it, Incyclist does not pick up the bridged heart rate.

DirectConnectPeripheral.services only returned the service UUIDs from the mDNS announcement. The trainer exposes the Heart Rate service (0x180D) through Direct Connect service discovery but does not advertise it in the announcement, so any check based on peripheral.services could not see it, and the HeartRate capability was never enabled.

What changed

  • DirectConnectPeripheral.services now returns the announced services merged with the services found via DiscoverServices, skipping duplicates by normalized UUID. Before discovery has run, the result is unchanged.
  • BleWahooDevice.features sets heartrate: true when the peripheral offers the Heart Rate service (supportsHeartRate()), so the FTMS adapter enables the HeartRate capability.

Other consumers of peripheral.services (power/HR detection in BleFitnessMachineDevice, HR check in the Bkool sensor) now also see discovered services over Direct Connect. BLE peripherals are not affected.

DirectConnectPeripheral.services only returned the service UUIDs from the
mDNS announcement, so the Heart Rate service a Wahoo KICKR exposes when it
bridges a paired HR strap over WiFi was never seen.

- DirectConnectPeripheral.services now merges discovered services into the
  announced ones, skipping duplicates by normalized UUID.
- BleWahooDevice.features sets heartrate=true when the peripheral offers
  the Heart Rate service, so the adapter enables the HeartRate capability.
@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

@gdoumen gdoumen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review my comment in this PR

Most critical is the verification of which class is actual used. You can do that with a manual test or a unit test

I also think the fix would have to be replicated as well for BLE - not everyone uses Wifi

Please also address the styling comment (4ch space and whitespace at the end)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants