Repository navigation
Detect heart rate bridged by Wahoo trainers over Direct Connect - #147
Open
friendlyFriend4000 wants to merge 1 commit into
Open
friendlyFriend4000 wants to merge 1 commit into
friendlyFriend4000 wants to merge 1 commit into
Conversation
DirectConnectPeripheral.services only returned the service UUIDs from the mDNS announcement, so the Heart Rate service a Wahoo KICKR exposes when it bridges a paired HR strap over WiFi was never seen. - DirectConnectPeripheral.services now merges discovered services into the announced ones, skipping duplicates by normalized UUID. - BleWahooDevice.features sets heartrate=true when the peripheral offers the Heart Rate service, so the adapter enables the HeartRate capability.
|
gdoumen
requested changes
Nov 9, 2026
gdoumen
left a comment
Contributor
There was a problem hiding this comment.
please review my comment in this PR
Most critical is the verification of which class is actual used. You can do that with a manual test or a unit test
I also think the fix would have to be replicated as well for BLE - not everyone uses Wifi
Please also address the styling comment (4ch space and whitespace at the end)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
When a Wahoo KICKR CORE 2 trainer is connected over WiFi (Direct Connect) with a heart rate strap paired to it, Incyclist does not pick up the bridged heart rate.
DirectConnectPeripheral.servicesonly returned the service UUIDs from the mDNS announcement. The trainer exposes the Heart Rate service (0x180D) through Direct Connect service discovery but does not advertise it in the announcement, so any check based onperipheral.servicescould not see it, and the HeartRate capability was never enabled.What changed
DirectConnectPeripheral.servicesnow returns the announced services merged with the services found viaDiscoverServices, skipping duplicates by normalized UUID. Before discovery has run, the result is unchanged.BleWahooDevice.featuressetsheartrate: truewhen the peripheral offers the Heart Rate service (supportsHeartRate()), so the FTMS adapter enables the HeartRate capability.Other consumers of
peripheral.services(power/HR detection inBleFitnessMachineDevice, HR check in the Bkool sensor) now also see discovered services over Direct Connect. BLE peripherals are not affected.