Skip to content

fix(connect): refresh environment renaming onto current main - #3

Open
PixPMusic wants to merge 1171 commits into
inayayousfi:feat/rename-environmentsfrom
PixPMusic:pixpmusic/refresh-rename-environments
Open

PixPMusic wants to merge 1171 commits into
inayayousfi:feat/rename-environmentsfrom
PixPMusic:pixpmusic/refresh-rename-environments

Conversation

@PixPMusic

@PixPMusic PixPMusic commented Sep 10, 2026 •

Copy link
Copy Markdown

Updates pingdotgg#7267 onto current pingdotgg/main (b7b3ef1e6f) and resolves its conflicts while retaining the six original commits and their authorship. The conflict resolutions preserve the newer server identity split, config projection module, theme/usage streams, machine icons, and mobile styling.

The review found two additional correctness issues: older clients received an unknown environmentLabelUpdated event, and an unresponsive relay could hang label synchronization indefinitely. Label events now require an explicit client opt-in, and relay requests have a ten-second timeout within the existing retry flow. Updated Effect APIs and test fixtures, restored name truncation, fixed the mobile spinner's theme color, and added concise user guidance.

The final merge commit only preserves the original PR head as a parent; its tree is identical to the rebased result. Merge this satellite PR with a merge commit to retain current main's ancestry. The large overall diff includes upstream changes since the original branch; review the feature diff against current main and the follow-up fixes separately.

Validation on Node 24.13.1:

  • 317 focused tests passed across contracts, shared client state, server startup/config streams, MCP, relay synchronization, and relay notification/linking tests. This includes a reproduced-and-fixed legacy-client regression and a virtual-clock relay timeout test.
  • Typechecks passed for contracts, client-runtime, server, web, mobile, and relay.
  • Targeted lint and formatting passed; existing unrelated lint warnings remain. git diff --check passed.
  • Reviewed both mobile entry points, web/desktop Settings, rename/reset, and direct/relay connections. No provider-specific changes.

Browser verification on this refresh passed in an isolated, seeded T3 environment: rename with Save and Enter, cancel with Escape without leaving Settings, persistence after page reload, live rename/reset propagation to a second connected tab, and clearing the override to restore the machine name. Native mobile and hosted relay end-to-end verification remain outstanding.

Fresh screenshots from the updated branch (before and after renaming):

Before: Studio Mac After: Build server
Before rename After rename

Model: GPT-6 Astra | Harness: Codex in T3 Code

t3dotgg and others added 30 commits September 5, 2026 21:47
…tgg#10021)

Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
…gdotgg#9754)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
…gdotgg#10305)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…g#10130)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
simplythatguy and others added 28 commits September 8, 2026 22:52
…ingdotgg#10416)

Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Store environment names on the server so every client and T3 Connect share one label.

Add authorized rename controls for web, desktop, and mobile with live propagation.
Preserve saved labels during mobile URL edits.

Prevent startup and relay synchronization races, and align the web rename action.
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 6c10eccc-34ab-4ee4-9991-e687ed09ac1b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.