Repository navigation
Conversation
…tgg#10021) Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
…gdotgg#9754) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
…10324) Co-authored-by: Claude Code <noreply@anthropic.com>
…gdotgg#10305) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…g#10130) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ingdotgg#10848) Co-authored-by: Ryan Hughes <ryan@heyoodle.com>
…10851) Co-authored-by: Ryan Hughes <ryan@heyoodle.com>
…ingdotgg#10416) Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Store environment names on the server so every client and T3 Connect share one label. Add authorized rename controls for web, desktop, and mobile with live propagation.
Preserve saved labels during mobile URL edits. Prevent startup and relay synchronization races, and align the web rename action.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates pingdotgg#7267 onto current
pingdotgg/main(b7b3ef1e6f) and resolves its conflicts while retaining the six original commits and their authorship. The conflict resolutions preserve the newer server identity split, config projection module, theme/usage streams, machine icons, and mobile styling.The review found two additional correctness issues: older clients received an unknown
environmentLabelUpdatedevent, and an unresponsive relay could hang label synchronization indefinitely. Label events now require an explicit client opt-in, and relay requests have a ten-second timeout within the existing retry flow. Updated Effect APIs and test fixtures, restored name truncation, fixed the mobile spinner's theme color, and added concise user guidance.The final merge commit only preserves the original PR head as a parent; its tree is identical to the rebased result. Merge this satellite PR with a merge commit to retain current main's ancestry. The large overall diff includes upstream changes since the original branch; review the feature diff against current main and the follow-up fixes separately.
Validation on Node 24.13.1:
git diff --checkpassed.Browser verification on this refresh passed in an isolated, seeded T3 environment: rename with Save and Enter, cancel with Escape without leaving Settings, persistence after page reload, live rename/reset propagation to a second connected tab, and clearing the override to restore the machine name. Native mobile and hosted relay end-to-end verification remain outstanding.
Fresh screenshots from the updated branch (before and after renaming):
Model: GPT-6 Astra | Harness: Codex in T3 Code