feat: glob-based copy_to_workspace for fixture seeding - #8
Merged
Conversation
8 tasks
devzeebo
commented
Aug 30, 2026
devzeebo
left a comment
Collaborator
Author
There was a problem hiding this comment.
Requesting changes from review: destination collisions are skipped silently, from is cwd-resolved (README example is misleading), empty globs is a no-op, destinations are not confined to workspace, Vitest is a static optional-peer import, and glob expansion walks the entire from tree. Error tests also do not assert that nothing was copied. Fixing these on the branch next.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copy_to_workspace(workspace, globs, options?)so specs can seed the temp workspace from fixture globs instead of one-offwriteFilecalls (#6).from); optionalbasestrips a matching path prefix. Empty globs and base mismatches throw before copying.from.Test plan
pnpm test— unit suite includingcopy_to_workspacecasesfixtures/**intothis.workspacewithout passingfrombase: "fixtures/*"drops the first two path segmentsbasethrow and leave the workspace empty