Repository navigation
chore: run the privacy check as part of verify - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Summary
Before:
scripts/privacy-check.mjsscans tracked files for home-directory paths, private keys and inline API keys, but no npm script, CI job or doc ever ran it. So the PR template's "No secrets or machine-specific paths added" box was never actually checked.After:
npm run verify, and therefore CI, runs the privacy check first and fails the build if it matches anything.How: this adds an
npm run privacyscript, puts it at the front ofverify, and mentions the step in the README commands table anddocs/testing.md. The check passes on the current tree.Verification
npm run privacypasses, and format, lint, types, tests and build are unchanged