Repository navigation
fix: return client errors for malformed, blank, and oversized requests - #13
Merged
Merged
Conversation
autoantohaki
force-pushed
the
fix/http-client-error-status
branch
from
October 21, 2026 21:55
37b907b to
d6eded8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Summary
Before: requests that were the client's fault came back as
500 Internal Server Erroron/v1/chatand/v1/chat/stream. That covered malformed JSON, whitespace-onlyinput(which passed the schema and was then rejected by the runner), and bodies over the 1 MB limit. On the stream endpoint, blank input even got a200followed by anerrorevent. Each one was also logged as a server failure.After: malformed JSON and blank input return
400, oversized bodies return413, and the agent is never invoked for any of them.How:
readJsonthrows a smallRequestErrorcarrying its status, the request schema rejects whitespace-only input, and both handlers map errors to a status through oneerrorStatushelper. A new test covers all three cases on both endpoints. It fails onmainwithexpected 500 to be 400and passes here.docs/http-api.mdnow lists the status codes.Verification
npm run verify(format, lint, types, tests with coverage, and build all pass locally)