Implement Email Notification Orchestrator pattern with typed config, builders, renderer, and tests - #4
Open
imagineux wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
NotificationType,NotificationDefinition,NotificationProperties(loaded via@ConfigurationProperties), andNotificationCatalogfor lookups.EmailNotificationOrchestratorthat loads config, resolves a builder fromNotificationModelBuilderRegistry, renders viaTemplateRenderer, builds anEmailPublicationRequest, and publishes viaEmailPublicationPublisher.NotificationModelBuilder<T>plus concrete buildersHoldListCreatedModelBuilderandHoldListRemovedModelBuilderto show extensibility without changing orchestration flow.TemplateRenderer+ThymeleafTemplateRenderer), a publisher contract (EmailPublicationPublisher), a logging publisher stub, example domain usage (HoldListDomainService),application.ymlentries, Thymeleaf templates underresources/templates, and an expandedREADMEwith pattern rationale and checklist.Testing
EmailNotificationOrchestratorTestandNotificationModelBuilderRegistryTestwhich assert render/publish flow and payload-type safety respectively.mvn testin this environment, but the run failed because Maven could not resolve the Spring Boot parent POM from Maven Central (HTTP 403), so tests did not execute here.EmailNotificationOrchestratorTest,NotificationModelBuilderRegistryTest).Codex Task