optimizations

.github/workflows/ci.yml

@@ -78,5 +78,6 @@ jobs:
           bundle exec rake coverage:report
 
       - uses: joshmfrankel/simplecov-check-action@main
+        if: ${{ github.repository == 'igrigorik/http-2' }}
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}

.rubocop.yml

@@ -17,6 +17,8 @@ Layout/HeredocIndentation:
     - 'lib/tasks/generate_huffman_table.rb'
     - 'example/*'
 
+Layout/LeadingCommentSpace:
+  AllowRBSInlineAnnotation: true
 
 Metrics/BlockLength:
   Enabled: false

.simplecov

@@ -7,5 +7,4 @@ SimpleCov.start do
   add_filter "/spec/"
   add_filter "/lib/http/2/base64"
   coverage_dir "coverage"
-  minimum_coverage(RUBY_ENGINE == "truffleruby" ? 85 : 90)
 end

CHANGELOG.md

@@ -1,3 +1,16 @@
+## 1.2.0
+
+### Improvements
+
+A lot of optimizations around reducing allocated objects, avoiding expensive frequent operations, and simpler data structures. A few highlights:
+
+* precompute huffman padding bytes.
+* use `String#bytesplice` (when available) to save an intermediate string in buffer ops.
+* bookkeep header dynamic table offsets to improve lookups.
+* streams recently closed: use `Hash#delete_if` with early break instead of `Hash#delete_while` to avoid intermediate hash.
+* Store frame flags as integers instead of arrays of symbols in frame hashes.
+  * NOTE: while frame hashes are an internal representation, they get exposed via `:frame_received` or `:frame_sent` callbacks. in case you're relying on the `:flags` field, you'll have to adapt your code accordingly.
+
 ## 1.1.3
 
 HTTP2::FrameBuffer#clear: clears the buffered data chunks

Rakefile

@@ -41,7 +41,9 @@ namespace :coverage do
     require "simplecov"
 
     puts Dir["coverage/**/.resultset.json"].inspect
-    SimpleCov.collate Dir["coverage/**/.resultset.json"]
+    SimpleCov.collate Dir["coverage/**/.resultset.json"] do
+      minimum_coverage 95
+    end
   end
 end
 
@@ -94,7 +96,7 @@ task :h2spec do
           "Or Download the binary from https://github.com/summerwind/h2spec/releases"
   end
 
-  server_pid = Process.spawn("ruby example/server.rb -p 9000", out: File::NULL)
+  server_pid = Process.spawn({ "RUBYOPT" => nil }, "ruby example/server.rb -p 9000", out: File::NULL)
   sleep RUBY_ENGINE == "ruby" ? 5 : 20
   system("#{h2spec} -p 9000 -o 2 --strict")
   Process.kill("TERM", server_pid)

lib/http/2/client.rb

@@ -69,7 +69,7 @@ def send_connection_preface
     end
 
     def self.settings_header(settings)
-      frame = Framer.new.generate(type: :settings, stream: 0, payload: settings)
+      frame = Framer.new.generate(type: :settings, stream: 0, flags: 0, payload: settings)
       Base64.urlsafe_encode64(frame[9..-1])
     end