Define Darwin GMP limb flag for witness builds#413
Open
Kuhai9801 wants to merge 2 commits into
Open
Conversation
Kuhai9801
force-pushed
the
long-long-limb-witness-build
branch
from
bd7c50f to
005335c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-D_LONG_LONG_LIMBfor generated C++ witness builds on Darwinjson2bin64compile path and add generated Makefile regression coverageWhy
On Darwin, GMP limb types can require
_LONG_LONG_LIMBfor generated witness C++ to agree with GMP'smp_limb_tlayout. Linux and other platforms keep an empty flag.Addresses #351.
Test
cargo test -p code_producers -- --test-threads=1cargo build -p circommasterfails with GMPuint64_t *tomp_ptrconversion errors, while this branch builds the generated witness successfully: https://github.com/Kuhai9801/circom/actions/runs/26813644848