Ensure deterministic output - #883
Merged
Merged
Conversation
Author
|
@owenlejeune can you check if this fixes it for you? not sure I'm testing this right. |
|
i'd be happy to test a version with this integrated! |
Author
|
@Alex009 what's a good way to do a dev build of this so we can test? |
|
How can I test and help with this? I have interest on this because my case is the same as #882 |
|
@Alex009 just wanted to check in on any updates to this |
Contributor
|
Hi, |
ExNDY
self-requested a review
August 27, 2026 15:40
Signed-off-by: Brian Witt <brianwitt@gmail.com>
bwitt
force-pushed
the
deterministic-builds
branch
from
August 27, 2026 23:21
caa01eb to
7c7bd82
Compare
Author
|
@ExNDY added tests, how does that look? does not seem to run the tests here in CI though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few things that were preventing determinism:
Also add tests
Fixes #882