Skip to content

Fix component props type and update tests#19

Open
TheMatrixan wants to merge 2 commits intoianschmitz:masterfrom
TheMatrixan:master
Open

Fix component props type and update tests#19
TheMatrixan wants to merge 2 commits intoianschmitz:masterfrom
TheMatrixan:master

Conversation

@TheMatrixan
Copy link
Copy Markdown

  • I removed any types from the function and replaced them with React type utils.
  • I added JSDoc to make it easier to use in development - developer will be able to see how to use this function without leaving VSCode.
  • I added Given-When-Then to tests to make them more readable.

@nikeee
Copy link
Copy Markdown

nikeee commented Jan 16, 2024

Can I help getting this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants