fix: do not treat digits as word boundaries in camelCase conversion - #58
Open
Yanhu007 wants to merge 1 commit into
Open
fix: do not treat digits as word boundaries in camelCase conversion#58Yanhu007 wants to merge 1 commit into
Yanhu007 wants to merge 1 commit into
Conversation
Digits were setting capNext=true, causing the first letter after
a digit sequence to be capitalized. This produced incorrect results
for common patterns like k8s, l10n, v2:
ToLowerCamel("k8s_version") → "k8SVersion" (wrong)
ToLowerCamel("l10n_us") → "l10NUs" (wrong)
Now digits do not trigger capitalization — only explicit delimiters
(underscore, space, dash, dot) create word boundaries:
ToLowerCamel("k8s_version") → "k8sVersion" (correct)
ToLowerCamel("l10n_us") → "l10nUs" (correct)
Fixes iancoleman#51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51
Problem
Digits set
capNext = true, causing the first letter after a digit to be capitalized:Fix
Remove the
capNext = truefor digits. Only explicit delimiters (_,-,.) create word boundaries:One test expectation updated to reflect the new behavior.
All existing tests pass.