Skip to content

Find the Prompt Node tests' buttons by text, not role (1.5 s -> 0.1 s) #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianarawjo merged 1 commit into from
Oct 22, 2026
Merged

Find the Prompt Node tests' buttons by text, not role (1.5 s -> 0.1 s) #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions chainforge/react-server/src/backend/__test__/promptNodeBehavior.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,9 @@ const type = (container: HTMLElement, value: string) =>
});

const clickRun = () =>
fireEvent.click(screen.getByRole("button", { name: "▶" }));
// By its text, not getByRole: in jsdom, a role query works out every
// element's accessible role and name, which here takes about a second
fireEvent.click(screen.getByText("▶").closest("button") as HTMLElement);

/** What was saved to the flow, by property. */
const saved = (prop: string) =>
Expand Down Expand Up @@ -303,7 +305,9 @@ describe("a Prompt Node, as it always has", () => {
// The variant controls' trash icon comes before the models'
const trash = container.querySelector(".tabler-icon-trash") as SVGElement;
fireEvent.click(trash.closest("button") as HTMLButtonElement);
fireEvent.click(await screen.findByRole("button", { name: "Confirm" }));
fireEvent.click(
(await screen.findByText("Confirm")).closest("button") as HTMLElement,
);
await wait(0);
expect(saved("prompt")).toEqual([["A", "C"]]);
expect(saved("promptVariantLabel")).toEqual([]);
Expand Down
4 changes: 3 additions & 1 deletion chainforge/react-server/src/backend/__test__/promptNodeRunEdits.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,9 @@ const type = (container: HTMLElement, value: string) =>
});

const clickRun = () =>
fireEvent.click(screen.getByRole("button", { name: "▶" }));
// By its text, not getByRole: in jsdom, a role query works out every
// element's accessible role and name, which here takes about a second
fireEvent.click(screen.getByText("▶").closest("button") as HTMLElement);

/** What each query was sent: its prompt, its models and its inputs. */
const promptsSent = () => mockQueryLLM.mock.calls.map((call) => call[3]);
Expand Down
Loading