Skip to content

Fork validation for #1373 (upstream #1339): persist debug, canary and improve-mode state #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianalitis wants to merge 1 commit into from
Closed

Fork validation for #1373 (upstream #1339): persist debug, canary and improve-mode state #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions crates/jcode-base/src/session/persistence.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,16 @@ impl Session {
// id find no file and silently treat the session as missing.
// Parent linkage is also explicit state: an empty fork carries only a
// hidden fork notice but must be loadable when its new client attaches.
// The debug and canary flags are explicit state by the same argument
// (#1339): `create_headless_session` sets them on a session that has no
// messages, title or parent yet, and `Agent::set_debug` saves
// immediately, so skipping the write here drops the flag silently - the
// save returns `Ok(())`, nothing is logged, and a later load-by-id fails
// with ENOENT.
// `improve_mode` is explicit state for the same reason and reaches the
// same failure: a caller that sets it and saves before the first visible
// message gets no file, so its own load-by-id fails
// (`test_improve_mode_persists_in_session_file`).
if !self.persist_state.snapshot_exists
&& !self
.messages
Expand All @@ -396,6 +406,9 @@ impl Session {
&& self.custom_title.is_none()
&& self.title.is_none()
&& self.parent_id.is_none()
&& self.improve_mode.is_none()
&& !self.is_debug
&& !self.is_canary
{
return Ok(());
}
Expand Down
Loading