fork: TUI test isolation fix (also open upstream as #1366)

[ianalitis]

Fork-side PR so this change is reviewed by Greptile here as well as upstream.

The same commit is open upstream as 1jehuang#1366
for issue 1jehuang#1365.

gather_git_info spawns a live git probe in test binaries again on master,
so jcode-tui --lib failure sets are order-dependent and differ per runner.
This restores the #[cfg(test)] read-only path from 1jehuang#1133 and narrows one
frame assertion that depended on how many frames the process had rendered.

cargo test -p jcode-tui --lib -- --test-threads=1: 19 failed before, 17 after
(2332 -> 2334 passing).

Confidence Score: 4/5

The PR is not yet safe to merge because the updated account-clearing test selects a label that cannot exist and therefore fails before exercising the behavior under test.

Findings

1.  Unreachable test cache branch ▶
2.  Switch test proves no transition ▶

Fix with agent prompt

### Issue 1
crates/jcode-tui/src/tui/app/helpers.rs:1124-1131
This block can never compile: the enclosing function has `#[cfg(not(test))]`, so test builds exclude the whole function, while non-test builds exclude this inner block. The active `#[cfg(test)]` implementation at lines 1094–1103 already provides the read-only cache behavior. Keeping this duplicate dead code makes the explanation misleading and creates a second implementation that can drift from the real test path.

```suggestion

```

### Issue 2
crates/jcode-tui/src/tui/app/tests/commands_accounts_02/part_01.rs:553-560
This test asserts that the only inserted OpenAI account is already active, then asks `/account switch` to select that same account. The final assertion would therefore still pass if command submission or the switch operation were a no-op. Create a second account and make a different account active before submitting the command so this remains a meaningful regression test.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

This PR prevents test builds from probing the live Git repository and makes a background-task rendering assertion target the suppressed card rather than unrelated box-drawing UI.

• Adds a read-only Git-info cache path for tests while retaining stale-while-revalidate behavior in production.
• Replaces a frame-wide border assertion with content-specific suppression checks.
• Changes made since the previous review also restore incorrect hardcoded account-label assumptions in an unrelated test.

_{Reviews (3) · Last reviewed commit: "fix(tui): stop the live git probe leakin..."}

[greptile-apps]

Unreachable test cache branch

This block can never compile: the enclosing function has #[cfg(not(test))], so test builds exclude the whole function, while non-test builds exclude this inner block. The active #[cfg(test)] implementation at lines 1094–1103 already provides the read-only cache behavior. Keeping this duplicate dead code makes the explanation misleading and creates a second implementation that can drift from the real test path.

Suggested change

	#[cfg(test)]
	{
	return GIT_INFO_CACHE
	.lock()
	.ok()
	.and_then(|guard| guard.as_ref().map(|(_, cached, _)| cached.clone()))
	.flatten();
	}

Prompt To Fix With AI

This is a comment left during a code review.
Path: crates/jcode-tui/src/tui/app/helpers.rs
Line: 1124-1131

Comment:
**Unreachable test cache branch**

This block can never compile: the enclosing function has `#[cfg(not(test))]`, so test builds exclude the whole function, while non-test builds exclude this inner block. The active `#[cfg(test)]` implementation at lines 1094–1103 already provides the read-only cache behavior. Keeping this duplicate dead code makes the explanation misleading and creates a second implementation that can drift from the real test path.

```suggestion

```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

[greptile-apps]

Switch test proves no transition

This test asserts that the only inserted OpenAI account is already active, then asks /account switch to select that same account. The final assertion would therefore still pass if command submission or the switch operation were a no-op. Create a second account and make a different account active before submitting the command so this remains a meaningful regression test.

Prompt To Fix With AI

This is a comment left during a code review.
Path: crates/jcode-tui/src/tui/app/tests/commands_accounts_02/part_01.rs
Line: 560-567

Comment:
**Switch test proves no transition**

This test asserts that the only inserted OpenAI account is already active, then asks `/account switch` to select that same account. The final assertion would therefore still pass if command submission or the switch operation were a no-op. Create a second account and make a different account active before submitting the command so this remains a meaningful regression test.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[ianalitis]

Closing this fork-side validation PR now that the corresponding upstream PR 1jehuang#1366 was merged. Keeping the branch untouched.